Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Add the typings to the package exports #633

Merged
merged 1 commit into from
Jun 21, 2023
Merged

fix: Add the typings to the package exports #633

merged 1 commit into from
Jun 21, 2023

Conversation

susnux
Copy link
Contributor

@susnux susnux commented Jun 12, 2023

This is required to make the package work with typescript projects which set the module resolution to node16 or nodenext (only the exports field is evaluated but not the types field).

@susnux
fix: Add the typings to the package exports so typescript with node16…
ca981c0 
… resolution works

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@susnux susnux added bug Something isn't working 3. to review labels Jun 12, 2023
@skjnldsv skjnldsv merged commit c1c951d into master Jun 21, 2023
@skjnldsv skjnldsv deleted the fix/package-exports-for-node16 branch June 21, 2023 07:14
@susnux susnux mentioned this pull request Jun 25, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChristophWurst ChristophWurst ChristophWurst approved these changes

@skjnldsv skjnldsv skjnldsv approved these changes

Assignees
No one assigned
Labels
3. to review bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@susnux @ChristophWurst @skjnldsv